Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): adds hex version of address to addresses command #960

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

qrayven
Copy link
Contributor

@qrayven qrayven commented Jul 28, 2023

Description of change

Adds the hex version of the address when listing the addresses. This allows the user to identify the address in the details of transactions, outputs, etc.
Another possible solution would be using the Bech32 format when printing the Transaction, Output etc. This is not feasible, because bech32 requires HRP which is not available during formatting.

Links to any relevant issues

closes #677

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

manually:
image

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@qrayven qrayven marked this pull request as ready for review July 28, 2023 08:20
@qrayven qrayven merged commit 83a8c12 into iotaledger:1.1 Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants